-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#263 klipper support #274
#263 klipper support #274
Conversation
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 89.98% 89.84% -0.14%
==========================================
Files 137 137
Lines 6129 6163 +34
==========================================
+ Hits 5515 5537 +22
- Misses 614 626 +12
Continue to review full report at Codecov.
|
In the future we might have to improve the TMC DIAG active_low option. This mode of operation is designed so that all TMC drivers can share the same DIAG line. We haven't encountered this yet on any of the boards we use, but it is theoretically possible to have something like this. I think the DUET2 WIFI board is like this with their drivers, but that is a SAMD based board anyway. |
Yep, there's definitely work to be done when we encounter additional features in use (for example, boards with both DIAG lines configured to different things. But better to implement it at point of need rather than get mired down in the specifics too soon 👍 |
Description
Changes required for Klipper support, both SimAVR and the main FW.
Behaviour/ Breaking changes
Adds
--skew-correct
to force the simulation to try to track wall time.Tweaks heater off-time so it doesn't cool as much when not at 100% PWM
LCD now ignores writes when it is busy.
Have you tested the changes?
Yes - locally and @leptun have confirmed that Klipper appears to be working.
Linked issues: