Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#237 - remove all non inline and template code from headers. #245

Merged
merged 7 commits into from
Sep 28, 2020

Conversation

vintagepc
Copy link
Owner

Description

General cleanup of cruft from header files.

Behaviour/ Breaking changes

No net changes to the code, only reorg.

Have you tested the changes?

N/A - automated tests.

Linked issues:

@github-actions
Copy link

github-actions bot commented Sep 28, 2020

Automated Test Code Coverage Report

View details...

File Lines Exec Cover
MK404.cpp 203 192 94%
parts/ADCPeripheral.h 30 30 100%
parts/BasePeripheral.h 30 30 100%
parts/Board.cpp 218 184 84%
parts/Board.h 34 31 91%
parts/I2CPeripheral.cpp 72 64 88%
parts/I2CPeripheral.h 8 8 100%
parts/IKeyClient.cpp 3 3 100%
parts/IKeyClient.h 1 1 100%
parts/IScriptable.cpp 47 31 65%
parts/IScriptable.h 3 3 100%
parts/KeyController.cpp 43 43 100%
parts/KeyController.h 3 2 66%
parts/PinSpec.h 10 10 100%
parts/Printer.cpp 13 11 84%
parts/Printer.h 4 4 100%
parts/PrinterFactory.cpp 22 16 72%
parts/PrinterFactory.h 19 19 100%
parts/SPIPeripheral.h 20 20 100%
parts/ScriptHost.cpp 277 201 72%
parts/ScriptHost.h 13 13 100%
parts/Scriptable.cpp 17 15 88%
parts/Scriptable.h 2 2 100%
parts/SoftPWMable.cpp 17 17 100%
parts/SoftPWMable.h 9 9 100%
parts/TelemetryHost.cpp 106 71 66%
parts/TelemetryHost.h 11 7 63%
parts/Wiring.h 10 10 100%
parts/boards/EinsyRambo.cpp 136 129 94%
parts/boards/EinsyRambo.h 1 1 100%
parts/boards/MM_Control_01.cpp 61 61 100%
parts/boards/MM_Control_01.h 3 3 100%
parts/boards/MiniRambo.cpp 88 88 100%
parts/boards/MiniRambo.h 3 3 100%
parts/boards/Test_Board.cpp 87 87 100%
parts/boards/Test_Board.h 3 3 100%
parts/components/A4982.cpp 174 174 100%
parts/components/A4982.h 5 5 100%
parts/components/ADC_Buttons.cpp 51 48 94%
parts/components/ADC_Buttons.h 1 1 100%
parts/components/Beeper.cpp 92 71 77%
parts/components/Beeper.h 4 4 100%
parts/components/Button.cpp 39 39 100%
parts/components/Button.h 2 2 100%
parts/components/EEPROM.cpp 86 71 82%
parts/components/EEPROM.h 1 1 100%
parts/components/Fan.cpp 82 81 98%
parts/components/Fan.h 2 2 100%
parts/components/GCodeSniffer.cpp 24 24 100%
parts/components/GCodeSniffer.h 3 3 100%
parts/components/GLHelper.cpp 81 78 96%
parts/components/GLHelper.h 1 1 100%
parts/components/HC595.cpp 39 36 92%
parts/components/HC595.h 2 2 100%
parts/components/HD44780.cpp 247 193 78%
parts/components/HD44780.h 14 14 100%
parts/components/HD44780GL.cpp 105 105 100%
parts/components/HD44780GL.h 1 1 100%
parts/components/Heater.cpp 97 96 98%
parts/components/Heater.h 2 2 100%
parts/components/IRSensor.cpp 65 63 96%
parts/components/IRSensor.h 1 1 100%
parts/components/LED.cpp 38 38 100%
parts/components/MMU1.cpp 54 54 100%
parts/components/MMU1.h 2 2 100%
parts/components/MMU2.cpp 109 98 89%
parts/components/MMU2.h 1 1 100%
parts/components/PAT9125.cpp 140 114 81%
parts/components/PAT9125.h 6 6 100%
parts/components/PINDA.cpp 127 120 94%
parts/components/PINDA.h 2 2 100%
parts/components/RotaryEncoder.cpp 106 103 97%
parts/components/RotaryEncoder.h 3 3 100%
parts/components/SDCard.cpp 310 290 93%
parts/components/SDCard.h 9 9 100%
parts/components/SerialLineMonitor.cpp 89 81 91%
parts/components/SerialLineMonitor.h 1 1 100%
parts/components/TMC2130.cpp 183 171 93%
parts/components/TMC2130.h 5 5 100%
parts/components/Thermistor.cpp 56 52 92%
parts/components/Thermistor.h 1 1 100%
parts/components/UART_Logger.cpp 0 0 --%
parts/components/VoltageSrc.cpp 31 29 93%
parts/components/VoltageSrc.h 2 2 100%
parts/components/uart_pty.cpp 157 127 80%
parts/components/uart_pty.h 3 3 100%
parts/components/w25x20cl.cpp 201 177 88%
parts/components/w25x20cl.h 1 1 100%
parts/pinspecs/PinSpec_2560.h 2 2 100%
parts/pinspecs/PinSpec_32u4.h 2 2 100%
parts/printers/Prusa_MK1_13.cpp 15 15 100%
parts/printers/Prusa_MK1_13.h 1 1 100%
parts/printers/Prusa_MK25S_13.cpp 6 6 100%
parts/printers/Prusa_MK25S_13.h 1 1 100%
parts/printers/Prusa_MK25_13.cpp 15 15 100%
parts/printers/Prusa_MK25_13.h 1 1 100%
parts/printers/Prusa_MK2MMU_13.cpp 32 32 100%
parts/printers/Prusa_MK2MMU_13.h 1 1 100%
parts/printers/Prusa_MK2_13.cpp 112 83 74%
parts/printers/Prusa_MK2_13.h 1 1 100%
parts/printers/Prusa_MK3.cpp 8 8 100%
parts/printers/Prusa_MK3.h 1 1 100%
parts/printers/Prusa_MK3MMU2.cpp 9 9 100%
parts/printers/Prusa_MK3MMU2.h 1 1 100%
parts/printers/Prusa_MK3S.cpp 113 111 98%
parts/printers/Prusa_MK3S.h 2 2 100%
parts/printers/Prusa_MK3SMMU2.cpp 33 29 87%
parts/printers/Prusa_MK3SMMU2.h 3 3 100%
parts/printers/Test_Printer.cpp 39 39 100%
parts/printers/Test_Printer.h 3 3 100%
parts/wiring/Einsy_1_0a.h 6 6 100%
parts/wiring/Einsy_1_1a.h 19 19 100%
parts/wiring/MM_Control_01.h 6 6 100%
parts/wiring/Test_Wiring.h 6 6 100%
parts/wiring/miniRAMBo_1_1b.h 6 6 100%
parts/wiring/miniRAMBo_1_3a.h 20 20 100%
utility/Color.cpp 67 49 73%
utility/FatImage.cpp 83 75 90%
utility/FatImage.h 2 2 100%
utility/GLObj.cpp 180 171 95%
utility/GLObj.h 6 6 100%
utility/GLPrint.cpp 105 105 100%
utility/GLPrint.h 12 12 100%
utility/MK3SGL.cpp 446 400 89%
utility/MK3SGL.h 11 11 100%
utility/MK3S_Bear.cpp 79 78 98%
utility/MK3S_Bear.h 9 6 66%
utility/MK3S_Full.cpp 10 10 100%
utility/MK3S_Full.h 4 4 100%
utility/MK3S_Lite.cpp 72 71 98%
utility/MK3S_Lite.h 12 10 83%
utility/OBJCollection.cpp 16 16 100%
utility/OBJCollection.h 8 7 87%
utility/SerialPipe.cpp 62 39 62%
utility/Util.h 15 15 100%
TOTAL 6148 5546 90%

TOTAL: 6148 lines of code, 5546 lines executed, 90% covered.

@vintagepc vintagepc merged commit 89f61d5 into master Sep 28, 2020
@vintagepc vintagepc deleted the 237-remove-header-code branch September 28, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] No more code in .h files
1 participant