Severe error in filtering procedure - critical memory corruption

[vmarkovtsev]

Cascade.h, near line 181:

  // Process a block of samples in the given form
  template <class StateType, typename Sample>
  void process (int numSamples, Sample* dest, StateType& state) const
  {
    while (--numSamples >= 0)
      *dest++ = state.process (*dest, *this);
  }

There is a very stupid error: the order of calculation of *dest++ and *dest is unspecified (see this question on StackOverflow). It seems that with Visual C++ it does the right thing, but g++ under Linux compiles the other way, resulting in the first sample to be skipped. Moreover, this actually leads to memory corruption in the end. I recommend the following fix:

  // Process a block of samples in the given form
  template <class StateType, typename Sample>
  void process (int numSamples, Sample* dest, StateType& state) const
  {
    while (--numSamples >= 0) {
      *dest = state.process (*dest, *this);
      dest++;
    }
  }

[galchinsky]

Fixed in #10