Switch to Elogram

[vinkla]

The old Instagram package is dead. Instead we're going to move to the amazing Elogram by @hassankhan.

[vinkla]

@hassankhan out of curiosity, why is the client class final?

[hassankhan]

Because I didn't think there'd be any reason to extend it, anything you need to change/set should be doable through the constructor.

Is there something I might be missing?

[florianbeer]

Neat! Elogram looks really well done. Shame that I just worked on updating the other package. Seems like I'll do another refactor tomorrow to integrate with this one.

@vinkla Are you going to hook into Laravel's session handling? http://elogram.readthedocs.org/en/latest/developers.html#nativesessionstore

[hassankhan]

Hi @florianbeer, thanks for the kind words!

To answer your question to @vinkla, yes, I'm pretty sure it will have to be integrated with Laravel, much like Facebook's SDK.

[vinkla]

@hassankhan thanks for explaining.

@florianbeer yeah, I'll look into that. Thanks for pointing it out!

[hassankhan]

Just had a look at the Travis test results, trying to see if there's a way I can help without having to remove the final statement.

Checking Mockery's docs, maybe try instantiating the Client and then passing to Mockery::mock()? According to the docs, it should work

[vinkla]

@hassankhan nope, didn't work. Thanks for reaching out though.

[vinkla]

@hassankhan the tests pass now. Now it is only the custom session handling left. Anything else we need to think of before going further?

[hassankhan]

Yep, pretty sure you only need to replace the session handling 👍

[vinkla]

@hassankhan okay, good 👍

[hassankhan]

Awesome work 😄 thanks for choosing Elogram!

[vinkla]

Thanks :)