-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Status dos pedidos são divergentes da Vindi #70
Merged
laerte-guimaraes
merged 60 commits into
vindi:master
from
trezoteam:bugfix/VIND-30-status-assinatura
May 28, 2020
Merged
Status dos pedidos são divergentes da Vindi #70
laerte-guimaraes
merged 60 commits into
vindi:master
from
trezoteam:bugfix/VIND-30-status-assinatura
May 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…77/estrutura-basica
…cessários nesta release
Merge branch 'master' of github.com:vindi/vindi-magento2 # Conflicts: # README.md # app/code/Vindi/Payment/Model/Payment/Vindi.php # app/code/Vindi/Payment/etc/adminhtml/system.xml # app/code/Vindi/Payment/etc/config.xml # app/code/Vindi/Payment/etc/frontend/routes.xml # app/code/Vindi/Payment/etc/module.xml # app/code/Vindi/Payment/etc/payment.xml # app/code/Vindi/Payment/view/frontend/layout/checkout_index_index.xml # app/code/Vindi/Payment/view/frontend/web/template/payment/vindi.html
# Conflicts: # app/code/Vindi/Payment/Model/Payment/Vindi.php # app/code/Vindi/Payment/etc/adminhtml/system.xml # app/code/Vindi/Payment/etc/config.xml # app/code/Vindi/Payment/etc/module.xml # app/code/Vindi/Payment/etc/payment.xml # app/code/Vindi/Payment/view/frontend/layout/checkout_index_index.xml
Co-Authored-By: Laerte Guimarães <[email protected]>
Co-Authored-By: Laerte Guimarães <[email protected]>
Co-Authored-By: Laerte Guimarães <[email protected]>
Feature/trezo unit tests
Feature/trezo unit tests
leo-araujo
approved these changes
May 28, 2020
laerte-guimaraes
approved these changes
May 28, 2020
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
Merge pull request vindi#70 from cedran/master
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
Merge pull request vindi#88 from cedran/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivação
Isso não acontece hoje, o status é alterado após o primeiro pagamento, e nunca mais é alterado.
Isso é problemático pois o Magento não está refletindo (nas Orders) como as Assinaturas estão na Vindi.
Solução Proposta
No caso de cancelamento de Assinatura a Order deve ser atualizada para Cancelada, e o status Processing se refere a um status de pagamento, então, a Order só pode possuir esse status caso o pagamento tenha acontecido.
Close #63