Fix array<empty, empty> not in array{foo?: mixed}<string, mixed>#5677
Merged
muglug merged 2 commits intovimeo:masterfrom Apr 30, 2021
Merged
Fix array<empty, empty> not in array{foo?: mixed}<string, mixed>#5677muglug merged 2 commits intovimeo:masterfrom
muglug merged 2 commits intovimeo:masterfrom
Conversation
56e8b2b to
097721b
Compare
Contributor
Author
|
I can't decide if I should create a new file for the test or add one to an existing file ; any thought @muglug ? |
Collaborator
|
Merge/rebase master, where you'll find a |
Contributor
Author
|
Thanks @muglug, it works well. Test are failing without my fix. It's ready to be reviewed/improved :) |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #4963
I tried to modify my vendor and this seems to fix the issue but there is certainly some improvements.
I'm not familiar at all with the different types.
Should I do something with
Listtoo ? Is there an easier way to check for empty array ?