Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix int overflow #5369

Merged
merged 1 commit into from
Mar 12, 2021
Merged

fix int overflow #5369

merged 1 commit into from
Mar 12, 2021

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Mar 11, 2021

When int multiplication overflows PHP_INT_MAX, the resulting type is a float. It makes Psalm crash. This fix #5363

@muglug muglug merged commit 57234ab into vimeo:master Mar 12, 2021
@muglug
Copy link
Collaborator

muglug commented Mar 12, 2021

thanks!

pull bot pushed a commit to IMULMUL/psalm that referenced this pull request Mar 12, 2021
This was referenced Mar 15, 2021
This was referenced Mar 17, 2021
@orklah orklah deleted the max-int-to-float branch September 14, 2021 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Psalm 4.6.2 crashed due to an uncaught Throwable
2 participants