Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Mar 7, 2021

As the source indicates at

$config->level = 2;

Level 1 is the most strict, level 8 is the most lenient.

When no level is explicitly defined, psalm defaults to level 2.
In case `totallyTyped` is enabled, psalm defaults to level 1.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since totallyTyped is deprecated we might just drop this line for simplicity sake


Level 1 is the most strict, level 8 is the most lenient.

When no level is explicitly defined, psalm defaults to level 2.
Copy link

@dbrekelmans dbrekelmans Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this? I thought psalm scans the codebase and determines the appropriate level from that. Maybe I'm confused with something else... but just checking ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess its correct, see the cited code in the PR description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this? I thought psalm scans the codebase and determines the appropriate level from that.

I guess there is some kind of init command which guesses a proper default level when you use it.
I am talking about what psalm does when no level is defined in the config file at all.

@muglug muglug merged commit 5747f1d into vimeo:master Mar 11, 2021
@muglug
Copy link
Collaborator

muglug commented Mar 11, 2021

Thanks!

@staabm staabm deleted the patch-3 branch March 11, 2021 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants