-
Notifications
You must be signed in to change notification settings - Fork 685
docs: mention default level #5340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Level 1 is the most strict, level 8 is the most lenient. | ||
|
|
||
| When no level is explicitly defined, psalm defaults to level 2. | ||
| In case `totallyTyped` is enabled, psalm defaults to level 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since totallyTyped is deprecated we might just drop this line for simplicity sake
|
|
||
| Level 1 is the most strict, level 8 is the most lenient. | ||
|
|
||
| When no level is explicitly defined, psalm defaults to level 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? I thought psalm scans the codebase and determines the appropriate level from that. Maybe I'm confused with something else... but just checking ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess its correct, see the cited code in the PR description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? I thought psalm scans the codebase and determines the appropriate level from that.
I guess there is some kind of init command which guesses a proper default level when you use it.
I am talking about what psalm does when no level is defined in the config file at all.
|
Thanks! |
As the source indicates at
psalm/src/Psalm/Config.php
Line 848 in c05a3ea