Fix binding of T of static when called from a class scope

[robchett]

Partial fix for #11368

Issue appears to cement itself here -

psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/ArgumentAnalyzer.php

Lines 418 to 421 in e052de4

	!$statements_analyzer->isStatic()
	&& (!$method_id || $method_id->method_name !== '__construct')
	? $context->self
	: null,

as context->self = "User" but the method was called on an instance of UserId

After updating to

 !$statements_analyzer->isStatic()
    && (!$method_id || $method_id->method_name !== '__construct')
    ? ($method_id ? $method_id->fq_class_name : $context->self)
    : null,

https://psalm.dev/r/a32e05de27

ERROR: ArgumentTypeCoercion - 19:33 - Argument 1 of UserId1::equals expects User&static, but parent type UserId1 provided

becomes

ERROR: ArgumentTypeCoercion - 19:33 - Argument 1 of UserId1::equals expects UserId1&static, but parent type UserId1 provided

Now, using self instead of static works

    /**
     * @template T of self
     * @param T $uuid
     */
    final public function equals($uuid): void {}

I've seen the "A&static, but parent type A" style messaging elsewhere and unsure if this is now a legitimate issue or not.

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a32e05de27

<?php

abstract class Uuid
{
    /**
     * @template T of static
     * @param T $uuid
     */
    final public function equals($uuid): void {}
}

class UserId1 extends Uuid {}
class UserId2 extends Uuid {}

class User
{
    public function equals(self $user): void
    {
        (new UserId1())->equals(new UserId2());
    }
}

Psalm output (using commit 514e954):

ERROR: ArgumentTypeCoercion - 19:33 - Argument 1 of UserId1::equals expects User&static, but parent type UserId2 provided

[robchett]

Ignore the above snippet - I pasted the wrong link. https://psalm.dev/r/a32e05de27

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/a32e05de27

<?php

abstract class Uuid
{
    /**
     * @template T of static
     * @param T $uuid
     */
    final public function equals($uuid): void {}
}

class UserId1 extends Uuid {}
class UserId2 extends Uuid {}

class User
{
    public function equals(self $user): void
    {
        (new UserId1())->equals(new UserId2());
    }
}

Psalm output (using commit 514e954):

ERROR: ArgumentTypeCoercion - 19:33 - Argument 1 of UserId1::equals expects User&static, but parent type UserId2 provided