Regression: in 4.6.2, @psalm-assert iterable<T> does not refine ArrayIterator value

[Ocramius]

In 4.6.1, following code does not produce issues:

<?php

/**
 * @psalm-assert iterable<string> $value
 * @param mixed $value
 *
 * @return void
 */
function AssertAllString($value) : void
{
    throw new \Exception(\var_export($value, true)); // irrelevant
}

/**
 * @param ArrayIterator<string, mixed> $value
 *
 * @return ArrayIterator<string, string>
 */
function preserveContainerAllArrayIterator($value)
{
    AssertAllString($value);

    return $value;
}

In 4.6.2, the type is no longer refined:

Psalm output (using commit 594ef4f): 

INFO: MixedReturnTypeCoercion - 23:12 - The type 'ArrayIterator<string, mixed>' is more general than the declared return type 'ArrayIterator<string, string>' for preserveContainerAllArrayIterator

INFO: MixedReturnTypeCoercion - 17:12 - The declared return type 'ArrayIterator<string, string>' for preserveContainerAllArrayIterator is more specific than the inferred return type 'ArrayIterator<string, mixed>'

Ref https://psalm.dev/r/90e3413397

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/90e3413397

<?php

/**
 * @psalm-assert iterable<string> $value
 * @param mixed $value
 *
 * @return void
 */
function AssertAllString($value) : void
{
    throw new \Exception(\var_export($value, true)); // irrelevant
}

/**
 * @param ArrayIterator<string, mixed> $value
 *
 * @return ArrayIterator<string, string>
 */
function preserveContainerAllArrayIterator($value)
{
    AssertAllString($value);

    return $value;
}

Psalm output (using commit 594ef4f):

INFO: MixedReturnTypeCoercion - 23:12 - The type 'ArrayIterator<string, mixed>' is more general than the declared return type 'ArrayIterator<string, string>' for preserveContainerAllArrayIterator

INFO: MixedReturnTypeCoercion - 17:12 - The declared return type 'ArrayIterator<string, string>' for preserveContainerAllArrayIterator is more specific than the inferred return type 'ArrayIterator<string, mixed>'

[Ocramius]

That was fast 😱

…

On Wed, Mar 3, 2021, 06:13 Matthew Brown ***@***.***> wrote: Closed #5310 <#5310> via 4c65d3b <4c65d3b> . — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#5310 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABFVEBBWZXBKQJKPTF34NTTBXAPDANCNFSM4YPFMSWA> .