Fix crash on aliased exception

Ref #3465
vimeo · May 27, 2020 · ef53ee3 · ef53ee3
1 parent 769ac5c
commit ef53ee3
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Block/TryAnalyzer.php
@@ -211,6 +211,8 @@ public static function analyze(
                     $statements_analyzer->getAliases()
                 );
 
+                $fq_catch_class = $codebase->classlikes->getUnAliasedName($fq_catch_class);
+
                 if ($codebase->alter_code && $fq_catch_class) {
                     $codebase->classlikes->handleClassLikeReferenceInMigration(
                         $codebase,

diff --git a/tests/TryCatchTest.php b/tests/TryCatchTest.php
@@ -301,6 +301,31 @@ function foo() : void {
                         } while (rand(0, 1));
                     }'
             ],
+            'aliasException' => [
+                '<?php
+                    namespace UserException;
+
+                    class UserException extends \Exception {
+
+                    }
+
+                    namespace Alias\UserException;
+
+                    use function class_alias;
+
+                    class_alias(
+                        \UserException\UserException::class,
+                        \Alias\UserException\UserExceptionAlias::class
+                    );
+
+                    namespace Client;
+
+                    try {
+                        throw new \Alias\UserException\UserExceptionAlias();
+                    } catch (\Alias\UserException\UserExceptionAlias $e) {
+                        // do nothing
+                    }'
+            ],
         ];
     }