Skip to content

fix: Safari WebKit TDZ bug in loadAndParseVirtualFilePageEntry (fix #3121) #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brillout merged 5 commits into from
Feb 25, 2026
Merged

fix: Safari WebKit TDZ bug in loadAndParseVirtualFilePageEntry (fix #3121) #3122

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
152dfc0
fix: Safari WebKit TDZ bug in loadAndParseVirtualFilePageEntry
brillout Feb 25, 2026
ba853ca
re-run CI
brillout Feb 25, 2026
66a6347
re-run CI
brillout Feb 25, 2026
d16c6f0
re-run CI
brillout Feb 25, 2026
73d0be0
comment
brillout Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/vike/src/shared-server-client/page-configs/loadAndParseVirtualFilePageEntry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,16 @@ async function loadAndParseVirtualFilePageEntry(
// Catch @cloudflare/vite-plugin bug
assertVirtualFileExports(moduleExports, () => 'configValuesSerialized' in moduleExports, moduleId)
const virtualFileExportsPageEntry = moduleExports
const configValues = parseVirtualFileExportsPageEntry(virtualFileExportsPageEntry)
let configValues: ConfigValues
try {
configValues = parseVirtualFileExportsPageEntry(virtualFileExportsPageEntry)
} catch (e) {
if (!(e instanceof ReferenceError)) throw e
// Safari WebKit bug: dynamic import() may resolve before the module body executes,
// https://github.com/vikejs/vike/issues/3121
await new Promise<void>((resolve) => setTimeout(resolve))
configValues = parseVirtualFileExportsPageEntry(virtualFileExportsPageEntry)
}
Object.assign(pageConfig.configValues, configValues)
objectAssign(pageConfig, { isPageEntryLoaded: true as const })
return pageConfig
Expand Down
Loading