Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

np.product -> np.prod for np 2.0 compatibility #147

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

np.product -> np.prod for np 2.0 compatibility #147

wants to merge 1 commit into from

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 24, 2024

np.product does not exist anymore, np.prod should be used instead

@vmoens
Copy link
Contributor Author

vmoens commented Jul 2, 2024

@vikashplus The CI reports this thing (I think due to an H5-numpy version mismatch)

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

Also is branch -> dev still the right way of proposing changes in robohive?

@vikashplus
Copy link
Owner

Seems like it.
Unsure where it coming from. We don't pin to anything specific -
https://github.com/vikashplus/robohive/blob/main/setup.py#L51-L67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikashplus vikashplus vikashplus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vmoens @vikashplus