Skip to content

[Backport] fix: support multiple minisearch widget instances#8

Merged
vijay-wagento merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15485
Jun 4, 2018
Merged

[Backport] fix: support multiple minisearch widget instances#8
vijay-wagento merged 1 commit into2.1-developfrom
2.1-develop-PR-port-15485

Conversation

@vijay-wagento
Copy link
Copy Markdown
Owner

Original Pull Request

magento#15485

Description

When cloning the minisearch widget and changing the ID's and selectors they still trigger all instances as the label searchLabel is globally searched instead of in the form.

Manual testing scenarios

  1. clone module-search/view/frontend/templates/form.mini.phtml
  2. add custom block with the cloned and changed minisearch widget (after changing ID's and selectors in it)
  3. click on search icon on mobile

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vijay-wagento vijay-wagento merged commit 40d104f into 2.1-develop Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant