2.4.17 #606
Merged
2.4.17 #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1 of Cyberpunk Red Theme for Simple Calendar.
Removed a $ from infront of var that was not needed. Added a missing comma from the Theme list. Updated the module.json file to indicate support for version 12 of FoundryVTT. Updated how the authors color is retrieved for notes. In FoundryV12 the color was changed from a string to a class. Calling toString outputs the expected string from the class so doing that retains backwards compatability for earlier versions. Updated dependencies.
…es we use so we can deal with different version depreciation's. Updated all references to getRoute and mergeObject foundry utility functions to our new wrapper functions. Fixed a bug with notes where note categories could not be unselected after being selected.
Theme cyberpunk red core
…ths, the end date would appear as NaN. Fixed a bug when persistent open is set to true and the calendar is open, users could not deselect canvas items or open the main menu. Updated unit tests Updated dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 82 83 +1
Lines 7913 7975 +62
Branches 2352 2380 +28
=========================================
+ Hits 7913 7975 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundry V12 Support
Simple Calendar has been updated to support Foundry V12. It does not yet take advantage of the Application v2 but does remain backwards compatible with Foundry V10 and V11.
Cyberpunk Red Theme
A new theme has been added to Simple Calendar for the Cyberpunk Red system. Big thank you to RassilonMonk for creating this theme!
Bug Fixes