Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a second date line that doesn't line up with calender or time (pf2e system; don't know what the other line is from)[BUG] #534

Closed
fishrobe opened this issue Aug 23, 2023 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@fishrobe
Copy link

fishrobe commented Aug 23, 2023

Describe the bug
In chat timestamps, a second date line is added that doesn't match the PF2e system or the in-game clock.

To Reproduce
Make any roll with world time timestamps on (pf2e; haven't checked in other systems). This also happens when it is set to only post real-time--it uses the mystery time instead. I used Find the Culprit to confirm this is coming from Simple Calendar and not another module. Time for odd date is real-time. I don't know where the month/year are coming from.

Expected behavior
Expect to only have in-game time, or real-time.

Screenshots

Foundry Information

  • Foundry Version: v11 b307
  • Game System: [e.g. pf2e]
  • Simple Calendar Version: 2.3.20
  • Simple Calendar Configuration: [optional, can help in debugging custom calendars]
    weird date

Browser (please complete the following information):

  • Browser Vivaldi

Additional context
I'm using the Forge, though I don't think that would be an issue, thought I'd add it.

@fishrobe fishrobe added the bug Something isn't working label Aug 23, 2023
@vigoren
Copy link
Owner

vigoren commented Aug 23, 2023

Do you have the module DF Chat Enhancements?

If so it has an option to add chat message timestamps as well. I would check to see if that is enabled.

@fishrobe
Copy link
Author

I do, but when I turn it off, I only get the "2967 Kut" time, and Golarion time is gone entirely.

@fishrobe
Copy link
Author

If I disable Simple Calendar timestamps, it works ok, if the DF Enhancements box to use Simple Calendar is checked. I still don't know where the dates are coming from if they're both selected, but at least that fixed it. Thanks!

@fishrobe
Copy link
Author

Just dubble checked and even with DF completely disabled, I am only getting the weird date/time from SC.

@vigoren
Copy link
Owner

vigoren commented Aug 23, 2023

Without seeing how you have your calendars configured my guess you be you have more than one calendar configured and it is pulling the date from the second one. Those timestamps are generated by which of the configured calendars in SC is the active one.

If you follow the steps on this page you can at least see how many calendars are configured and switch to the correct one if the wrong one is currently active. If you don't see the calendar button in SC then you would only have 1 calendar configured.

If that is the case, or the correct calendar is set in SC, then I would recommend exporting your calendar configuration and sharing it with me so I can see why you are getting a weird time instead of the Golarion time.

@fishrobe
Copy link
Author

Thanks. I don't even have that button shown to switch calendars, so I assume I only have one, since that's how I set it up.

I'm not too worried about it. Just thought it was a neat feature, but I just turned it off for now, and turned off DF, too, since it's outdated and stopped playing nice with the most recent version of v11. (308)
calendar

@fishrobe
Copy link
Author

I can share my configuration with you anyway, so yoiiu can check it out. Not sure how to get it to you, though.

@vigoren
Copy link
Owner

vigoren commented Aug 25, 2023

Yeah that looks like just the one Calendar configured.

You can attach a file to a reply in GitHub. That would be the easiest way. Or you could send it to me in discord, my user name is vigorator

@fishrobe
Copy link
Author

fishrobe commented Aug 25, 2023 via email

@vigoren
Copy link
Owner

vigoren commented Sep 13, 2023

There was an issue with how timestamps were generated in PF2E. Version 2.4.0 of SC will fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants