Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Component] Logo Grid #5

Open
stephaniefois opened this issue Apr 10, 2024 · 0 comments
Open

[Component] Logo Grid #5

stephaniefois opened this issue Apr 10, 2024 · 0 comments
Assignees

Comments

@stephaniefois
Copy link
Contributor

stephaniefois commented Apr 10, 2024

Component Specs

Fields

{* Required element}

  • Logo
  • Text
    • If logo not available
  • URL link

Notes

  • Logos on a white background
  • Grid of logos
    • Define spacing and sizing

Design

Page Block - Logo Grid

Steph's Thoughts Implementation

  • By default this would be a single pattern
  • In most cases, a logo quilt is going to be the same logos in the same order whenever that pattern is used. For this reason, I think it's reasonable to have the pattern contain the logos
  • It's my understanding that if those logos needed to get updated, those edits would be done at the pattern level so that it updates where ever that pattern has been used.
bd-viget added a commit that referenced this issue Apr 22, 2024
bd-viget added a commit that referenced this issue Apr 22, 2024
bd-viget added a commit that referenced this issue Apr 22, 2024
bd-viget added a commit that referenced this issue Apr 22, 2024
bd-viget added a commit that referenced this issue Apr 22, 2024
bd-viget added a commit that referenced this issue Apr 23, 2024
* [#5] Logo Grid Component

* [#5] Image style

* [#5] Block template vs default pattern
@empee3 empee3 assigned empee3 and unassigned bd-viget Apr 24, 2024
empee3 pushed a commit that referenced this issue Apr 24, 2024
empee3 pushed a commit that referenced this issue Apr 25, 2024
empee3 pushed a commit that referenced this issue Apr 25, 2024
empee3 pushed a commit that referenced this issue Apr 25, 2024
* [#5] Style logo grid using Tailwind

* Add fix for image size in editor, move style directory

* Create column classes minus gap

* Spacing cleanup

* Nest CSS, add aspect ratio to figure

* Remove call to CSS in block.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants