-
Notifications
You must be signed in to change notification settings - Fork 2
Configuration updates #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Conversation
|
@joshuapease This is a medley of updates. Feel free to pick and choose or reject this PR |
joshuapease
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Wanna cherry-pick this commit onto your branch too?
a67da11#diff-9b414e2b2d19da12e2a4f2dad41c293fad185c1366d4825ada5e8e27a9aac3dc
It has all of the template changes needed for the parts kit.
Forgot I had made this branch
| ]) | ||
| ; | ||
| '@web' => App::env('PRIMARY_SITE_URL'), | ||
| '@primarySiteUrl' => StringHelper::removeRight(App::env('PRIMARY_SITE_URL'), '/'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a change to the site's project config that needs to happen here too?
…ags. - Shared <head> markup is moved to partial and configured in parts-kit.php
|
Does not need {% layout %} and {% block %} tags.
joshuapease
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran this PR though Cursor which is something I do lately.
It pointed out that I'd failed to migrated some of the parts kit templates.
Simplest thing was to push a commit to this PR with the remaining changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah... I realized we don't even have this plugin installed by default on the project.
With some of it's performance issues we've encountered (PHP has to download & parse JSON over S3, similar to the SVG over S3 issue), I'd recommend avoiding this as a default.
I do think it would be really cool to have repo or Notion doc with common configs & coding recipes. Not sure the place to keep that info
php-local.inito hide deprecation warnings)