fix: fix #4 ts support#5
Merged
viewweiwu merged 6 commits intoviewweiwu:masterfrom Mar 1, 2022
Merged
Conversation
Owner
|
感谢 PR，是否未提交 vue3-tabs-chrome.vue.d.ts |
Contributor
Author
|
不需要提交那个 lib打包的时候会自己生成。不过看起来这个pr还有点问题，文件名不太对 |
Owner
|
好的，等你改完我试试看 |
Contributor
Author
|
看起来这样就可以了，不过这冲突从哪冒出来的。。。我fork的时候好像还没那条四月份的commit。我是以volar为参照的 没看过webstorm这样对不对，按说volar能认得话就是标准的 |
Owner
|
非常感谢 PR，但是我本地测试感觉编译出来的东西非常的混乱。 还是建议把我那段代码复制到本地使用。 代码暂时先回退了。 |
Contributor
Author
|
还好吧 只是多了两个.d.ts 标准的组件类型定义，element之类的生成的也是这样，我也看不懂。但是volar能看懂，可以提供模板语法提示 |
Owner
|
会在其它目录产生 .d.ts 文件 |
Contributor
Author
因为vue-cli处理得有问题，要好点打包的话得自己写更详细的webpack脚本或者搞点vue-tsc啥的来做。所以我是用gitignore排除了。脚本用scp而不是mv也是因为没有powershell和bash通用的移动命令，可以考虑自己写个node脚本来做重命名和移动的事，不过我懒得写了 |
Owner
|
有点意思，我回头又试了一下，感觉你这个可以，可以把这部分代码加上。 如果有更好的优化，欢迎继续提供 PR。 |
Owner
|
目前暂时发布 0.3.0-beta.0，如果没有问题的话，马上发布 3.0。 yarn add vue3-tabs-chrome@0.3.0-beta.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #4
参考vuejs/vue-cli#1081 (comment)