This repository has been archived by the owner on Jan 29, 2019. It is now read-only.
Fix flash tag trimming to not append duplicate tags #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forbesjo
reviewed
Feb 28, 2017
src/flash-source-buffer.js
Outdated
| @@ -377,7 +377,7 @@ export default class FlashSourceBuffer extends videojs.EventTarget { | |||
| videoTargetPts *= 1e3; | |||
| videoTargetPts += this.basePtsOffset_; | |||
| } else { | |||
| videoTargetPts = this.videoBufferEnd_; | |||
| videoTargetPts = this.videoBufferEnd_ + 0.1; | |||
There was a problem hiding this comment.
I feel like these need comments
mjneil
force-pushed
the
fix-flash-rend-switch
branch
from
a8b9811
to
ecd4f40
Compare
forbesjo
approved these changes
Feb 28, 2017
|
Looks good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#136 introduced a change to track the last pts values of audio and video tags appended to the buffer to use as the target trim point for the next segment. This caused duplicate tags (usually the final GOP of the last segment appended) to be appended due to a
>=. This change adds a fudge factor of0.1to the target pts when using the last stored pts value to avoid mistakenly appending a duplicate GOP