-
Notifications
You must be signed in to change notification settings - Fork 793
Conversation
@@ -0,0 +1,39 @@ | |||
<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way we can unify this with the regular test harness so we don't have to update script locations in more places?
Other than my question about file organization, LGTM |
@@ -269,6 +282,16 @@ module.exports = function(grunt) { | |||
'concat', | |||
'uglify']); | |||
|
|||
grunt.registerTask('update-webdriver', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to break this process out into it's own module? Seems like the same function will be added to most of the grunts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking into enhancing grunt-protractor-runner so that it will automatically do this on install or with an option in the task.
I spoke too soon... would you mind adding instructions on how to run the functional tests to the README? |
Updated README with end-to-end browser information
@@ -190,7 +190,7 @@ the web](http://www.html5rocks.com/en/tutorials/track/basics/). | |||
### Testing | |||
|
|||
For testing, you can either run `npm test` or use `grunt` directly. | |||
If you use `npm test`, it will only run the karma tests using chrome. | |||
If you use `npm test`, it will only run the karma and end-to-end tests using chrome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So grunt test
would not run the end-to-end tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
grunt test
will run the end-to-end tests.
This PR is to add end to end tests run in Sauce Labs.