Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

Automated tests #323

Closed
wants to merge 5 commits into from
Closed

Automated tests #323

wants to merge 5 commits into from

Conversation

forbesjo
Copy link
Contributor

This PR is to add end to end tests run in Sauce Labs.

@@ -0,0 +1,39 @@
<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any way we can unify this with the regular test harness so we don't have to update script locations in more places?

@dmlap
Copy link
Member

dmlap commented Jun 24, 2015

Other than my question about file organization, LGTM

@@ -269,6 +282,16 @@ module.exports = function(grunt) {
'concat',
'uglify']);

grunt.registerTask('update-webdriver', function () {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to break this process out into it's own module? Seems like the same function will be added to most of the grunts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into enhancing grunt-protractor-runner so that it will automatically do this on install or with an option in the task.

@dmlap
Copy link
Member

dmlap commented Jun 24, 2015

I spoke too soon... would you mind adding instructions on how to run the functional tests to the README?

jforbes added 2 commits June 24, 2015 14:26
Updated README with end-to-end browser information
@@ -190,7 +190,7 @@ the web](http://www.html5rocks.com/en/tutorials/track/basics/).
### Testing

For testing, you can either run `npm test` or use `grunt` directly.
If you use `npm test`, it will only run the karma tests using chrome.
If you use `npm test`, it will only run the karma and end-to-end tests using chrome.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So grunt test would not run the end-to-end tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grunt test will run the end-to-end tests.

@forbesjo forbesjo closed this in 48eb8b7 Jun 26, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants