Refactor h264stream #272
Refactor h264stream #272
Conversation
gkatsev
force-pushed
the
refactor-h264frame
branch
from
6490d3a
to
047a6d7
Compare
The Random Access Indicator tells us whether something is a keyframe. Set the stream's frame's keyFrame property to true if the Random Access Indicator is set.
| adaptation_field_length, | ||
| afftemp, | ||
| discontinuity_indicator, | ||
| random_access_indicator, |
There was a problem hiding this comment.
we only really care about the random_access_indicator currently, so, I could remove the others if needed.
There was a problem hiding this comment.
There was a problem hiding this comment.
I know this code is very inconsistent about variable naming but we should stick with camel case.
There was a problem hiding this comment.
I literally copy/pasted this from the spec :), but yes, sticking with camel case is fine.
|
Looking into build failure. |
| @@ -0,0 +1,213 @@ | |||
| (function() { | |||
There was a problem hiding this comment.
I moved the H264ExtraData object into its own file instead of having it live inside of h264-stream.js
There was a problem hiding this comment.
In the future, please try to split refactor PRs from functionality-changing PRs so it's clearer what needs to be reviewed.
| h264Frame = new FlvTag(FlvTag.VIDEO_TAG); | ||
| h264Frame.pts = next_pts; | ||
| h264Frame.dts = next_dts; | ||
| if (this._nextFrameKeyFrame) { |
There was a problem hiding this comment.
when creating a new h264Frame, check to see if it'll be a keyframe.
| } else { | ||
| h264Frame.length -= 1; // 00 : 00 01 | ||
| } | ||
| H264Stream.prototype.setNextFrameKeyFrame = function() { |
There was a problem hiding this comment.
where the function is defined.
|
LGTM |
No description provided.