This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Trigger an event when the final playlist would have been blacklisted #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangs
force-pushed
the
feature/trigger-event-when-finalPlaylist-error
branch
from
cba6b68
to
caa0abd
Compare
mjneil
reviewed
Apr 13, 2017
| @@ -1135,6 +1143,7 @@ QUnit.test('playlist 404 should blacklist media', function(assert) { | |||
| assert.equal(this.env.log.warn.args[1], | |||
| 'Problem encountered with the current HLS playlist. Trying again since it is the final playlist.', | |||
| 'log specific error message for final playlist'); | |||
| assert.equal(retryplaylist, 1, 'retried final playlist for once'); | |||
There was a problem hiding this comment.
I think you should add a check here to make sure blacklistplaylist is still 1
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trigger an event when the final playlist would've been blacklisted
Might be a solution for #1074