This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
fix segment time mapping for fmp4 playback #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbcmdth
reviewed
Mar 30, 2017
| time: segmentInfo.timestampOffset, | ||
| mapping: segmentInfo.timestampOffset - timingInfo.start | ||
| time: segmentInfo.startOfSegment, | ||
| mapping: segmentInfo.startOfSegment - timingInfo.start |
There was a problem hiding this comment.
I think to ensure we don't introduce a regression in the future, we need a unit test around modification of timestampOffset (which we do in mp4Probe) to make sure it doesn't change the start and end time of the segment.
mjneil
force-pushed
the
fix/fmp4-time-mapping
branch
from
d145563
to
b5eac23
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Segment start and end times were being miscalculated for fragmented mp4s when
timestampOffsetwas being set.Specific Changes proposed
Use
segmentInfo.startOfSegmentfor setting the time mapping instead ofsegmentInfo.timestampOffset. These values are the same except in the fmp4 case whentimestampOffsetis adjusted to account for offset start times since fmp4 playback uses native source buffers instead of ourVirtualSourceBufferand transmuxer for settingbaseMediaDecodeTimeproperly.Requirements Checklist