This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Trigger player error on initial request error instead of media source error #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjneil
reviewed
Mar 24, 2017
src/master-playlist-controller.js
Outdated
| @@ -817,7 +817,7 @@ export class MasterPlaylistController extends videojs.EventTarget { | |||
| // trying to load the master OR while we were disposing of the tech | |||
| if (!currentPlaylist) { | |||
| this.error = error; | |||
| return this.mediaSource.endOfStream('network'); | |||
| return this.trigger('error'); | |||
There was a problem hiding this comment.
What about putting the endOfStream call in a try catch and if it fails trigger the error on MPC? I feel like we probably want to still call endOfStream in the common case of not hitting an InvalidStateError
gesinger
force-pushed
the
media-source-not-ready-errs
branch
from
16d221b
to
cd10763
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #575
This is to resolve an issue where we try to trigger an error on a media source that isn't yet ready.
Specific Changes proposed
Since we still want to trigger an error on the player, and can't use the media source (since it isn't ready yet), this fires the error directly on the player.
Requirements Checklist