This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
do not timeout segment requests for non-master playlist source #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbcmdth
reviewed
Feb 24, 2017
src/playlist-loader.js
Outdated
| return false; | ||
| } | ||
|
|
||
| if (!media.attributes) { |
There was a problem hiding this comment.
I think a better way would be to just always return true if there is only a single variant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the source loaded into the player is just a media playlist and not a master playlist, segments will still timeout after
1.5 * targetDurationeven though it is playing the lowest enabled rendition (seeing how its the only rendition)Addresses #1022
Requirements Checklist