This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
Reorganized the functions in SegmentLoader to better follow the flow of execution from top-down #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gesinger
reviewed
Feb 16, 2017
src/segment-loader.js
Outdated
| this.syncPoint_ = this.syncController_.getSyncPoint(this.playlist_, | ||
| this.mediaSource_.duration, | ||
| this.currentTimeline_, | ||
| this.currentTime_()); |
There was a problem hiding this comment.
This line I think is for a different PR
4 tasks
imbcmdth
force-pushed
the
reorganize-segmentloader
branch
from
a229782
to
74b4c40
Compare
added 2 commits
February 16, 2017 15:43
imbcmdth
force-pushed
the
reorganize-segmentloader
branch
from
74b4c40
to
e6177e6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a quality-of-life improvement. It was tedious to scroll around because execution didn't follow an orderly path through the file. Also helper functions and external functions were moved to the top for easier discovery.