This repository has been archived by the owner on Jan 12, 2019. It is now read-only.
isLowestEnabledRendition returns true when there are redundant streams #1004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbcmdth
reviewed
Feb 10, 2017
src/playlist-loader.js
Outdated
|
|
||
| }).length > 1); | ||
| }).length >= 1); |
There was a problem hiding this comment.
I think this boolean logic could use some cleaning up. Right now it says length not greater than or equal to one which is difficult to wrap my brain around. I think a better one is simply length is zero.
There was a problem hiding this comment.
yes, that will be much clear
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PlaylistLoader#isLowestEnabledRendition_ never returns true when there are redundant streams
Specific Changes proposed
return true when the lowest "rendition set" (all renditions sharing the same bandwidth) is selected.