Make sure that setSource is directly on prototype #1746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to make the new source handlers backwards compatible and so it wont break techs that extend existing techs that were converted to use source handlers.
|
Looks good to me. |
| @@ -1175,7 +1175,7 @@ vjs.Player.prototype.src = function(source){ | |||
|
|
|||
| // The setSource tech method was added with source handlers | |||
| // so older techs won't support it | |||
| if (this.tech['setSource']) { | |||
| if (window['videojs'][this.techName].prototype.hasOwnProperty('setSource')) { | |||
There was a problem hiding this comment.
You could also use this.tech.constructor.prototype to avoid the window ref, but not a requirement.
There was a problem hiding this comment.
I was following suit on line 1165 above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make the new source handlers backwards compatible and so it
wont break techs that extend existing techs that were converted to use
source handlers.