Skip to content
This repository has been archived by the owner on Dec 10, 2020. It is now read-only.

Fixes for initial setup and for packaging up less files #87

Merged
merged 1 commit into from
Apr 15, 2014

Conversation

bdeitte
Copy link
Contributor

@bdeitte bdeitte commented Apr 15, 2014

I wanted to make sure we had less files packaged up with npm pack here, as there's a huge number of files that were being included here that weren't needed. I ended up making a few extra changes as I tried the README that I haven't looked at in a long time. Changes include:

  1. Change npmignore so that only README and dist/video-js.swf are included
  2. Remove extra lines in README so that there's an ordered list instead of "1." many times
  3. Change testing section in README to reflect what's really there now
  4. Change index.html to indicate that the automated tests aren't working from the given link right now
  5. Update package.json's flex-sdk version to something that works. This is the number on npmjs.org, while the version that was in there was giving a 404

The two things I didn't fix that I saw were that the automated tests don't work out of the box, looks like some files that were used/copied before aren't there anymore. I just put a note on that. The second thing is that I didn't get the "Sandbox" link in index.html, which just seemed to be a blank page for me.

@heff
Copy link
Member

heff commented Apr 15, 2014

Awesome, thanks Brian. @seniorflexdeveloper do you want to review/accept this one?

@tomjohnson916
Copy link
Contributor

yeah @heff i will take a look at it this afternoon. looks pretty straightforward, just want to double check the flex-sdk issue because we've seen it elsewhere.

@gkatsev
Copy link
Member

gkatsev commented Apr 15, 2014

The flex-sdk issue has been resolved. npm had some issues with the tarball before the weekend. It's been fixed now. I've installed that version and it works.

tomjohnson916 added a commit that referenced this pull request Apr 15, 2014
Fixes for initial setup and for packaging up less files
@tomjohnson916 tomjohnson916 merged commit f178ab8 into videojs:master Apr 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants