This repository has been archived by the owner on Dec 10, 2020. It is now read-only.
HLS Segment Edge Seeking #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Removed extra console calls.
HTML expects buffered end time to be reported relative to the "start" of the video but the netstream reports it relative to the playhead position. In the model, add the buffered value coming from the netstream to the current playtime before returning it to javascript.
| @@ -53,8 +53,8 @@ package{ | |||
| _app.model.stageRect = new Rectangle(0, 0, stage.stageWidth, stage.stageHeight); | |||
|
|
|||
| // add content-menu version info | |||
| var _ctxVersion:ContextMenuItem = new ContextMenuItem("VideoJS Flash Component v4.0.0", false, false); | |||
| var _ctxAbout:ContextMenuItem = new ContextMenuItem("Copyright © 2013 Brightcove, Inc.", false, false); | |||
| var _ctxVersion:ContextMenuItem = new ContextMenuItem("VideoJS Flash Component v4.0.9", false, false); | |||
There was a problem hiding this comment.
Would there be any way we could load this version number in dynamically from the package.json?
There was a problem hiding this comment.
We should be able to yes.
There was a problem hiding this comment.
Doesn't need to happen now, but that would be cool to set up.
|
Made some comments that should be quick updates for the most part. This has a few changes in it that seem like they could affect standard mp4 playback, so I want to make sure this gets tested in IE8/Firefox, but otherwise it looks good to me. |
Previously, the position of the playhead was being added onto the buffered time both inside the HTTPVideoProvider and the model. Fixed it so that the playhead position is only added once, inside provider.
Instead of requiring an explicit call into the SWF to set the new starting offset for the netstream time, capture it when seekForSeconds is called in HTTPVideoProvider.
In order to distinguish between just running out of buffer and completing the stream when in data generation mode, it's necessary to signal back to the the HTTPVideoProvider. Media sources uses endOfStream to accomplish this so we're exposing that method on the SWF.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to close out some test behavior on videojs-contrib-hls plugin.