Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSR support #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SSR support #38

wants to merge 1 commit into from

Conversation

shlajin
Copy link

@shlajin shlajin commented Sep 17, 2020

Hey!
SSR complains about Blob/URL not being defined, which makes total sense. However, if a component imports this library (and never uses it during SSR) the app will still crash, as, for instance, Audio is an exported Blob.

This PR adds bunch of checks which allows the library to safely operate in SSR apps.
Thanks!

Related: #36

@timomeh
Copy link

timomeh commented Feb 19, 2021

I'm using @shlajin's fork and can confirm it works

@Johnrobmiller
Copy link

It's been about two years and apparently this PR works just fine. Why is this not being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants