fix: remove el on sendOutput (#49)

Fixes #48
video-dev · Aug 17, 2021 · 8999cba · 8999cba
1 parent b1d7013
commit 8999cba
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/build/can-autoplay.cjs.js b/build/can-autoplay.cjs.js
@@ -56,6 +56,10 @@ function startPlayback(_ref, elementCallback) {
     sendOutput = function sendOutput(result) {
       var error = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
 
+      // Clean up to avoid MediaElementLeak
+      element.remove();
+      element.srcObject = null;
+
       clearTimeout(timeoutId);
       resolve({ result: result, error: error });
     };

diff --git a/build/can-autoplay.es.js b/build/can-autoplay.es.js
@@ -54,6 +54,10 @@ function startPlayback(_ref, elementCallback) {
     sendOutput = function sendOutput(result) {
       var error = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
 
+      // Clean up to avoid MediaElementLeak
+      element.remove();
+      element.srcObject = null;
+
       clearTimeout(timeoutId);
       resolve({ result: result, error: error });
     };

diff --git a/build/can-autoplay.js b/build/can-autoplay.js
@@ -60,6 +60,10 @@ function startPlayback(_ref, elementCallback) {
     sendOutput = function sendOutput(result) {
       var error = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : null;
 
+      // Clean up to avoid MediaElementLeak
+      element.remove();
+      element.srcObject = null;
+
       clearTimeout(timeoutId);
       resolve({ result: result, error: error });
     };

diff --git a/lib/index.js b/lib/index.js
@@ -33,6 +33,10 @@ function startPlayback ({muted, timeout, inline}, elementCallback) {
       sendOutput(false, new Error(`Timeout ${timeout} ms has been reached`))
     }, timeout)
     sendOutput = (result, error = null) => {
+      // Clean up to avoid MediaElementLeak
+      element.remove()
+      element.srcObject = null
+
       clearTimeout(timeoutId)
       resolve({result, error})
     }
@@ -44,9 +48,6 @@ function startPlayback ({muted, timeout, inline}, elementCallback) {
     } else {
       sendOutput(true)
     }
-    // Clean up to avoid MediaElementLeak
-    element.remove()
-    element.srcObject = null
   })
 }