Incorrect engine setup results in duplicate deletion errors

[ujhelyiz]

Recently I have seen a lot of Duplicate deletion errors coming from VIATRA Base when working with MagicDraw models.

It seems that is caused by an incorrect engine setup: in https://github.com/viatra/v4md/blob/master/com.incquerylabs.v4md/src/main/com/incquerylabs/v4md/ViatraQueryAdapter.java#L57 all models of a projects are collected and then added to the base index as model roots.

Such a code is required as external models from TWS/TWC are not contained in the original project root; however it is problematic as e.g. in case of local projects referenced models are contained.

We should update the engine setup to handle such cases correctly.

[istvanrath]

2019-08-02 08:22:06,034 [AWT-EventQueue-0] INFO  GENERAL - Close Project task started.
2019-08-02 08:22:45,631 [pool-MagicDraw-thread-103:Close Project] ERROR org.eclipse.viatra.query.runtime.util.ViatraQueryLoggingUtil.org.eclipse.viatra.query.runtime.api.ViatraQueryEngine.1814111210 - Error: trying to remove duplicate value  from the unique feature org.eclipse.emf.ecore.impl.EAttributeImpl@69228e85 (name: name) (ordered: false, unique: true, lowerBound: 0, upperBound: 1) (changeable: true, volatile: false, transient: false, defaultValueLiteral: , unsettable: false, derived: false) (iD: false) of host object com.nomagic.uml2.ext.magicdraw.actions.mdbasicactions.impl.InputPinImpl@18338dd2. This indicates some errors in underlying model representation.
2019-08-02 08:22:45,633 [pool-MagicDraw-thread-103:Close Project] ERROR org.eclipse.viatra.query.runtime.util.ViatraQueryLoggingUtil.org.eclipse.viatra.query.runtime.api.ViatraQueryEngine.1814111210 - Error: trying to remove duplicate value public from the unique feature org.eclipse.emf.ecore.impl.EAttributeImpl@524a2ffb (name: visibility) (ordered: false, unique: true, lowerBound: 0, upperBound: 1) (changeable: true, volatile: false, transient: false, defaultValueLiteral: null, unsettable: false, derived: false) (iD: false) of host object com.nomagic.uml2.ext.magicdraw.actions.mdbasicactions.impl.InputPinImpl@18338dd2. This indicates some errors in underlying model representation.
2019-08-02 08:22:45,633 [pool-MagicDraw-thread-103:Close Project] ERROR org.eclipse.viatra.query.runtime.util.ViatraQueryLoggingUtil.org.eclipse.viatra.query.runtime.api.ViatraQueryEngine.1814111210 - Error: trying to remove duplicate value com.nomagic.uml2.ext.magicdraw.classes.mdkernel.impl.ClassImpl@fa62cedd from the unique feature org.eclipse.emf.ecore.impl.EReferenceImpl@3e104d4b (name: type) (ordered: false, unique: true, lowerBound: 0, upperBound: 1) (changeable: true, volatile: false, transient: false, defaultValueLiteral: null, unsettable: false, derived: false) (containment: false, resolveProxies: true) of host object com.nomagic.uml2.ext.magicdraw.actions.mdbasicactions.impl.InputPinImpl@18338dd2. This indicates some errors in underlying model representation.

[istvanrath]

It seems maybe the base index should be deattached before project closure?

[lunkpeter]

It not only appears when the project closes. Removing containment hierarchies can have the same effect.

[ujhelyiz]

Commit a0fa9cf adds a test case where we could demonstrate the duplicate EMF notifications using a single model delete (without relying on VIATRA).

We have discussed with @istvanrath in person that we should try to make this error message more user-friendly (e.g. do not include all details unless log level is set to info/debug or maybe reduce the default severity to warning in V4MD); we should think about it.

[ujhelyiz]

A quick solution was merged of notification suppressing - to have a cleaner solution we have to provide an API in VIATRA for it that takes longer time to implement. The API request is tracked by bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=549955