Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextflow runner: throw error when using a non-existent argument in a map passed to fromState #793

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

DriesSchaumont
Copy link
Contributor

@DriesSchaumont DriesSchaumont commented Dec 28, 2024

Describe your changes

Nextflow runner: throw error when using a non-existent argument in fromState

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@DriesSchaumont DriesSchaumont changed the base branch from main to develop December 28, 2024 09:08
@DriesSchaumont DriesSchaumont changed the title Nextflow runner: throw error when using a non-existent argument in fromState Nextflow runner: throw error when using a non-existent argument in a map passed to fromState Dec 28, 2024
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I like!

Can we do the same check on the toState values (not the keys)

@DriesSchaumont
Copy link
Contributor Author

Awesome, I like!

Can we do the same check on the toState values (not the keys)

Done

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, LGTM!

@DriesSchaumont DriesSchaumont merged commit 557abe6 into develop Jan 7, 2025
7 checks passed
@DriesSchaumont DriesSchaumont deleted the raise_invalid_argument_fromstate branch January 7, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants