Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're running the
fpb-lint
command 4 times to test each directory.This change makes the command take a list of directories instead of just 1.
After this, we can update free-programming-books from having 4 separate
run
steps to just:The motivation is to collate the linting to a single process, output, and exit code.
This will make it simpler later when/if we make more use of the output, like suggesting fixes and automatic suggestions on GitHub.
By merging the 4 runs into 1, this also incidentally addresses an issue we have with GitHub Actions where the build fails early. If warnings were displayed in
./books/
, it would fail and stop linting further files. This means there could be more warnings in./casts/
but the contributor wouldn't know until after fixing the warnings from./books/
.I added Commander as a dependency for 2 reasons:
\
), etc.