fix in upload session #377
Conversation
use file context manager to ensure file is closed iterate using partial: https://docs.python.org/3/library/functions.html#iter
beliaev-maksim
force-pushed
the
mbeliaev/upload_session
branch
from
4d264f4 to
e5c0316
Compare
| self._upload_results.append(upload_result) | ||
| elif f_pos + len(piece) < st.st_size: | ||
| upload_result = self.file.continue_upload(self._upload_id, f_pos, piece) | ||
| self._upload_results.append(upload_result) |
There was a problem hiding this comment.
@vgrem
also I am questioning the need to store the result. It is not used anywhere but consumes memory as well
or am I missing the place where it is utilized?
There was a problem hiding this comment.
Greetings! First of all, thank you for catching it! Agree with you, the way how it is implemented in the current version, does not prevent the whole file to be read into memory.
That basically contradicts to the advantage of utilizing lazy load approach which was supposed to bring an efficiency in terms of memory consumption.
And last but not least, thank you for the proposal and PR, lets merge it and see if works as expected.
There was a problem hiding this comment.
speaking of storing of results, right call! 👍
There was a problem hiding this comment.
great, thank you!
fix RAM leak in upload session #376
use file context manager to ensure file is closed
iterate using partial: https://docs.python.org/3/library/functions.html#iter