#861: fix FieldCollection.add method for choice field type

examples/sharepoint/fields/create_choice.py

@@ -0,0 +1,15 @@
+"""
+Demonstrates how to create lookup field
+"""
+from office365.sharepoint.client_context import ClientContext
+from tests import create_unique_name, test_client_credentials, test_team_site_url
+
+client = ClientContext(test_team_site_url).with_credentials(test_client_credentials)
+lib = client.web.default_document_library()
+
+field_name = create_unique_name("ChoiceField")
+
+choices = ["Not Started", "In Progress", "Completed", "Deferred"]
+field = lib.fields.add_choice_field(title=field_name, values=choices).execute_query()
+
+field.delete_object().execute_query()  # clean up

office365/sharepoint/fields/choice.py

@@ -1,5 +1,5 @@
-from office365.sharepoint.fields.field import Field
+from office365.sharepoint.fields.multi_choice import FieldMultiChoice
 
 
-class FieldChoice(Field):
+class FieldChoice(FieldMultiChoice):
     """Represents a choice field control."""

office365/sharepoint/fields/collection.py

@@ -222,9 +222,7 @@ def add(self, field_create_information):
 
         :type field_create_information: office365.sharepoint.fields.creation_information.FieldCreationInformation
         """
-        return_type = Field.create_field_from_type(
-            self.context, field_create_information
-        )
+        return_type = Field.create_field(self.context, field_create_information)
         self.add_child(return_type)
         qry = CreateEntityQuery(self, return_type, return_type)
         self.context.add_query(qry)

office365/sharepoint/fields/field.py

@@ -14,8 +14,11 @@ class Field(Entity):
     def __init__(self, context, resource_path=None):
         super(Field, self).__init__(context, resource_path)
 
+    def __str__(self):
+        return self.title or self.entity_type_name
+
     def __repr__(self):
-        return self.internal_name or self.id
+        return self.internal_name or self.id or self.entity_type_name
 
     @staticmethod
     def resolve_field_type(type_id_or_name):
@@ -63,7 +66,7 @@ def resolve_field_type(type_id_or_name):
                 return Field
 
     @staticmethod
-    def create_field_from_type(context, field_parameters):
+    def create_field(context, field_parameters):
         """
         Creates a field based on its type