Skip to content

Origin checks for polkadot-native asset registration on AH#57

Merged
vgeddes merged 18 commits intovgeddes:snowbridge-v2from
yrong:ron/register-token-origin-as-owner
Mar 18, 2025
Merged

Origin checks for polkadot-native asset registration on AH#57
vgeddes merged 18 commits intovgeddes:snowbridge-v2from
yrong:ron/register-token-origin-as-owner

Conversation

@yrong
Copy link
Copy Markdown
Collaborator

@yrong yrong commented Mar 11, 2025

For comment

Add origin checks on AH to ensure that the EthereumSystemFrontend::register_token extrinsic on AH is only allowed to register Polkadot-native assets for valid origins: Origins must be the owner of the asset in the Assets or ForeignAssets pallet on AH.

@yrong yrong marked this pull request as ready for review March 12, 2025 16:40
Copy link
Copy Markdown

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! +1

@github-actions github-actions Bot requested a review from acatangiu March 13, 2025 14:06
@github-actions
Copy link
Copy Markdown

Review required! Latest push from author must always be reviewed

yrong and others added 6 commits March 13, 2025 22:11
Comment thread bridges/snowbridge/runtime/runtime-common/src/register_token.rs Outdated
Comment thread bridges/snowbridge/runtime/runtime-common/src/register_token.rs Outdated
Comment thread bridges/snowbridge/runtime/runtime-common/src/register_token.rs Outdated
Comment thread bridges/snowbridge/runtime/runtime-common/src/fee_handler.rs
Comment thread bridges/snowbridge/runtime/runtime-common/src/lib.rs
@vgeddes vgeddes changed the title Allow only the asset owner to register it on BH Origin checks for polkadot-native asset registration on AH Mar 17, 2025
yrong and others added 6 commits March 18, 2025 09:50
Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Co-authored-by: Vincent Geddes <117534+vgeddes@users.noreply.github.com>
Comment thread bridges/snowbridge/runtime/runtime-common/src/v2/register_token.rs Outdated
Comment thread bridges/snowbridge/runtime/runtime-common/src/v2/register_token.rs Outdated
yrong and others added 2 commits March 18, 2025 17:26
…n.rs

Co-authored-by: Adrian Catangiu <adrian@parity.io>
…n.rs

Co-authored-by: Adrian Catangiu <adrian@parity.io>
@github-actions github-actions Bot requested a review from acatangiu March 18, 2025 09:26
@vgeddes vgeddes merged commit 11377b4 into vgeddes:snowbridge-v2 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants