Fix broken first-bounce random seed

vga-group · Oct 11, 2022 · 8212058 · 8212058
1 parent 61abf6b
commit 8212058
Show file tree

Hide file tree

Showing 7 changed files with 13 additions and 18 deletions.
diff --git a/external/fuchsia_radix_sort b/external/fuchsia_radix_sort
diff --git a/shader/random_sampler.glsl b/shader/random_sampler.glsl
@@ -29,7 +29,7 @@ random_sampler init_random_sampler(
     uvec4 coord, uvec3 size
 ){
     random_sampler rsampler;
-    rsampler.seed = coord;
+    rsampler.seed = pcg4d(coord);
     return rsampler;
 }
 

diff --git a/shader/sampling_sobol_owen.glsl b/shader/sampling_sobol_owen.glsl
@@ -90,7 +90,7 @@ vec4 get_shuffled_scrambled_sobol_pt(sobol_sampler ssampler, uint bounce)
 sobol_sampler init_sobol_sampler(uvec4 seed)
 {
     sobol_sampler ssampler;
-    ssampler.seed = seed;
+    ssampler.seed = pcg4d(seed);
     return ssampler;
 }
 #endif
diff --git a/src/aabb_scene.cc b/src/aabb_scene.cc
@@ -183,12 +183,10 @@ void aabb_scene::init_acceleration_structures(const char* timer_name)
             vk::BuildAccelerationStructureFlagBitsKHR::ePreferFastTrace|
             vk::BuildAccelerationStructureFlagBitsKHR::eAllowUpdate,
             vk::BuildAccelerationStructureModeKHR::eBuild,
-            {},
-            {},
+            VK_NULL_HANDLE,
+            VK_NULL_HANDLE,
             1,
-            &geom,
-            {},
-            {}
+            &geom
         );
 
         vk::AccelerationStructureBuildSizesInfoKHR size_info =

diff --git a/src/context.hh b/src/context.hh
@@ -7,6 +7,7 @@
 #include "render_target.hh"
 #include <set>
 #include <map>
+#include <memory>
 #include <chrono>
 #include <functional>
 

diff --git a/src/mesh.cc b/src/mesh.cc
@@ -40,12 +40,10 @@ void build_acceleration_structure(
         vk::AccelerationStructureTypeKHR::eBottomLevel,
         {},
         vk::BuildAccelerationStructureModeKHR::eBuild,
-        {},
-        {},
+        VK_NULL_HANDLE,
+        VK_NULL_HANDLE,
         1,
-        &geom,
-        {},
-        {}
+        &geom
     );
 
     if(static_as)

diff --git a/src/scene.cc b/src/scene.cc
@@ -346,12 +346,10 @@ void scene::init_tlas(size_t i)
         vk::BuildAccelerationStructureFlagBitsKHR::ePreferFastTrace|
         vk::BuildAccelerationStructureFlagBitsKHR::eAllowUpdate,
         vk::BuildAccelerationStructureModeKHR::eBuild,
-        {},
-        {},
+        VK_NULL_HANDLE,
+        VK_NULL_HANDLE,
         1,
-        &geom,
-        {},
-        {}
+        &geom
     );
 
     vk::AccelerationStructureBuildSizesInfoKHR size_info =