Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add vespa program to vespa-clients RPM" #20076

Conversation

aressem
Copy link
Member

@aressem aressem commented Nov 18, 2021

Reverts #20069

RPM building failed:

07:56:07 Processing files: vespa-7.504.2-1.el8.x86_64
07:56:07 error: Missing build-id in /vespa/vespa-rpmbuild/BUILDROOT/vespa-7.504.2-1.el8.x86_64/opt/vespa/bin/vespa
07:56:07 error: Generating build-id links failed
07:56:07 
07:56:07 
07:56:07 RPM build errors:
07:56:07     Missing build-id in /vespa/vespa-rpmbuild/BUILDROOT/vespa-7.504.2-1.el8.x86_64/opt/vespa/bin/vespa
07:56:07     Generating build-id links failed

@hakonhall hakonhall merged commit 171a0b3 into master Nov 18, 2021
@hakonhall hakonhall deleted the revert-20069-hakonhall/add-vespa-program-to-vespa-clients-rpm branch November 18, 2021 08:16
@hakonhall
Copy link
Member

Apparently this comes from RPM verifying the binaries contains a GNU build-id, which a go binary do not have by default (they make their own build-id). rpm-software-management/rpm#367 contains a discussion of this issue.

The alternatives I see are:
A. Specify -ldflags=-linkmode=external with the go build command.
B. Disable build-id checking for vespa-clients RPM with %global _missing_build_ids_terminate_build 0

@aressem
Copy link
Member Author

aressem commented Nov 18, 2021

I think B is ok.

@hakonhall
Copy link
Member

Alright, implemented in #20077 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants