-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix meta's cleanup not work as expected #5321
Conversation
Codecov ReportBase: 77.67% // Head: 78.70% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #5321 +/- ##
==========================================
+ Coverage 77.67% 78.70% +1.03%
==========================================
Files 1110 1119 +9
Lines 83422 83624 +202
==========================================
+ Hits 64798 65817 +1019
+ Misses 18624 17807 -817
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird... hope that clean up part is not called to many times.
Will the receiving snapshot happen very often? If not, I think that's fine. Or if it happens very often, the performance and availability will also be impacted even without this cleanup. |
* fix meta has not cleanup when reset (#5321) * support upgrade from V2 to V3.4 (#5319) Co-authored-by: Sophie <[email protected]> * fix meta update (#5326) * fix meta update * fix bug --------- Co-authored-by: Sophie <[email protected]> --------- Co-authored-by: Doodle <[email protected]> Co-authored-by: hs.zhang <[email protected]>
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close https://github.com/vesoft-inc/nebula-ent/issues/2399
Close #5320
Description:
Meta does not clean up all data before receiving snapshot... The bug must have existed for quite a long time...
How do you solve it?
Delete all data by delete range. The code is quite ugly, but I don't think of any better ways...
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: