Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fold constant for List/Set expression #4901

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Fold constant for List/Set expression #4901

merged 1 commit into from
Nov 18, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Nov 17, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4898

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Nov 17, 2022
yixinglu
yixinglu previously approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job! LGTM

yixinglu
yixinglu previously approved these changes Nov 17, 2022
View reviewed changes
@czpmango czpmango force-pushed the enhance/fold-in-expr branch 4 times, most recently from a2c4241 to 3b90fb0 Compare November 18, 2022 10:25
@czpmango
Fold constant for List/Set Expression
51b15f0 
fix ut

small comment

small delete

small change for ut

small fix

fix lookup

fix tck

fix tck

fix lookup index selection related to logicalOr expression

fix lookup

fix lookup index selection

fix lookup

small delete

small fix
@Sophie-Xie Sophie-Xie merged commit 90a3107 into vesoft-inc:master Nov 18, 2022
@wey-gu wey-gu mentioned this pull request Nov 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenhaocs wenhaocs wenhaocs left review comments

@Aiee Aiee Aiee left review comments

@jievince jievince jievince approved these changes

@yixinglu yixinglu yixinglu approved these changes

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
auto-sync ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fold constant for set
6 participants
@czpmango @yixinglu @Aiee @wenhaocs @jievince @Sophie-Xie