Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Nan & Infinity comparison And Value's operator/ & operator% #4893

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

codesigner
Copy link
Contributor

@codesigner codesigner commented Nov 17, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4894

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 84.56% // Head: 76.94% // Decreases project coverage by -7.61% ⚠️

Coverage data is based on head (2f5f1ed) compared to base (63a63ac).
Patch coverage: 87.98% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4893      +/-   ##
==========================================
- Coverage   84.56%   76.94%   -7.62%     
==========================================
  Files        1358     1110     -248     
  Lines      136387    82129   -54258     
==========================================
- Hits       115331    63197   -52134     
+ Misses      21056    18932    -2124     
Impacted Files Coverage Δ
src/common/datatypes/Value.h 97.05% <ø> (ø)
src/common/function/FunctionManager.cpp 79.32% <ø> (-0.05%) ⬇️
src/graph/executor/admin/SubmitJobExecutor.cpp 56.94% <ø> (+0.78%) ⬆️
src/kvstore/Listener.h 39.13% <ø> (ø)
src/kvstore/Part.h 100.00% <ø> (ø)
src/kvstore/raftex/RaftPart.h 100.00% <ø> (ø)
src/kvstore/wal/FileBasedWal.h 100.00% <ø> (ø)
src/storage/context/StorageExpressionContext.h 64.15% <ø> (ø)
src/storage/mutate/UpdateEdgeProcessor.h 100.00% <ø> (+41.66%) ⬆️
src/storage/mutate/UpdateVertexProcessor.h 100.00% <ø> (ø)
... and 320 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@czpmango czpmango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants