-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong properties prune in length
function.
#4884
Fix wrong properties prune in length
function.
#4884
Conversation
static const std::unordered_set<std::string> ignoreFuncs = { | ||
"src", "dst", "type", "typeid", "id", "rank", "length"}; | ||
"src", "dst", "type", "typeid", "id", "rank" /*, "length"*/}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we check if the argument type is path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do it in later optimization. This PR just fix bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember It was to optimze length(path) related query in ldbc. @nevermore3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we can add the type of the variable to the operator later, which can be more precise when clipping attributes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4862
Description:
length
function also could accept STRING input but not only PATH. So for compatibility, I disable this optimization. It lead to performance regression whenreturn length(p)
only.How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: