fix download always return succeeded #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liwenhui-soul
approved these changes
Jul 19, 2022
panda-sheep
approved these changes
Jul 19, 2022
| } else { | ||
| return Status::Error(folly::stringPrintf("Failed to run %s", command.c_str())); | ||
| try { | ||
| folly::Subprocess proc(std::vector<std::string>({command})); |
This was referenced Jul 19, 2022
This was referenced Jul 21, 2022
SuperYoko
reviewed
Sep 23, 2022
| } else { | ||
| return Status::Error(folly::stringPrintf("Failed to run %s", command.c_str())); | ||
| try { | ||
| folly::Subprocess proc(std::vector<std::string>({command})); |
There was a problem hiding this comment.
Here actually may have some trouble with system environment variable. May use /bin/bash/ -c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #4321, #4382
Description:
ProcessUtils::runCommandwill always return ok. So we can't tell whether hdfs command succeeded or not.How do you solve it?
Use SubProcess to execute shell command.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
After this PR, if the hdfs address is illegal, the
show jobis weird (job failed but task succeed), probably same as #4263, will try to fix it later.Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: