Supports older version of schema for index write #2073
Conversation
bright-starry-sky
requested review from
darionyaphet,
dangleptr,
critical27,
liuyu85cn and
panda-sheep
| } | ||
| { | ||
| cpp2::ExecutionResponse resp; | ||
| auto query = "ALTER TAG person ADD (col1 int)"; |
There was a problem hiding this comment.
Does it work well when we change the prop name or type? It's better to test it.
There was a problem hiding this comment.
Does it work well when we change the prop name or type? It's better to test it.
Don't allow to alter tag change column or alter tag drop column when the tag attached index. An error message will be return.
If you want to alter tag change column or alter tag drop column , need drop index firstly.
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
==========================================
- Coverage 86.90% 86.83% -0.08%
==========================================
Files 636 639 +3
Lines 59819 61129 +1310
==========================================
+ Hits 51984 53079 +1095
- Misses 7835 8050 +215
Continue to review full report at Codecov.
|
When insert vertex, need to check if an old index exists, if so, drop the old index and write a new index. At this point, an old index key needs to be assembled by old prop for index check, however, the old property values do not have this new column. so leads to
storagedcrash byCHECK(prop).Improved this logic，When an invalid property value appears, write index skipped .
repeat step :