Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: i18n #352

Merged
merged 4 commits into from
Nov 18, 2022
Merged

refactor: i18n #352

merged 4 commits into from
Nov 18, 2022

Conversation

hetao92
Copy link
Contributor

@hetao92 hetao92 commented Nov 11, 2022

mod: code review

@hetao92 hetao92 changed the title refactor: i18n 【TODO】refactor: i18n Nov 11, 2022
@hetao92 hetao92 force-pushed the hetao-fix branch 2 times, most recently from 49ee9b5 to e8d8683 Compare November 17, 2022 09:22
mod: code review

mod: code review

mod: code review

mod: code review

mod: code review

mod: update i18n

mod: update rule validator

mod: update version
@hetao92 hetao92 changed the title 【TODO】refactor: i18n refactor: i18n Nov 18, 2022
NicolaCage
NicolaCage previously approved these changes Nov 18, 2022
Copy link
Contributor

@NicolaCage NicolaCage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@huaxiabuluo huaxiabuluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huaxiabuluo huaxiabuluo merged commit 40e5757 into vesoft-inc:master Nov 18, 2022
@hetao92 hetao92 deleted the hetao-fix branch November 18, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants