Skip to content

Initial Nebula Stats Exporter #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2020
Merged

Initial Nebula Stats Exporter #2

merged 1 commit into from
Feb 24, 2020

Conversation

knightXun
Copy link
Contributor

this is initial Nebula Stats Exporter Pr. this PR convert nebula original metrics to promethues metrics.

@knightXun knightXun requested a review from yixinglu February 10, 2020 05:41
@knightXun
Copy link
Contributor Author

@yixinglu I make a mistake, sorry.

@knightXun
Initial Pr
38e99fc 
add gitigore
@knightXun knightXun mentioned this pull request Feb 10, 2020
Closed
yixinglu
yixinglu reviewed Feb 10, 2020
View reviewed changes
Copy link

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closed pr can be reopened. 🤣

@knightXun knightXun requested a review from monadbobo February 11, 2020 09:20
yixinglu
yixinglu approved these changes Feb 11, 2020
View reviewed changes
Copy link

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

monadbobo
monadbobo approved these changes Feb 20, 2020
View reviewed changes
Copy link

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yixinglu yixinglu merged commit 038abb8 into vesoft-inc:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yixinglu yixinglu yixinglu approved these changes

+1 more reviewer

@monadbobo monadbobo monadbobo approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knightXun @monadbobo @yixinglu