-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add executeJsonWithParameter, executeJson to SessionPool #580
Conversation
there's two checkstyle violations, could you please format the code? |
@Nicole00 ok |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
============================================
- Coverage 63.33% 62.83% -0.50%
+ Complexity 812 811 -1
============================================
Files 72 72
Lines 4006 4036 +30
Branches 542 547 +5
============================================
- Hits 2537 2536 -1
- Misses 1098 1128 +30
- Partials 371 372 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!Thanks @cjdxhjj very much!
@Nicole00 thanks |
Thank you for your great contribution, cjdxhjj. |
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
add executeJsonWithParameter, executeJson to SessionPool
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: