Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add executeJsonWithParameter, executeJson to SessionPool #580

Merged
merged 3 commits into from
Jan 12, 2024
Merged

add executeJsonWithParameter, executeJson to SessionPool #580

merged 3 commits into from
Jan 12, 2024

Conversation

cjdxhjj
Copy link
Contributor

@cjdxhjj cjdxhjj commented Jan 1, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

add executeJsonWithParameter, executeJson to SessionPool

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@Nicole00
Copy link
Contributor

Nicole00 commented Jan 8, 2024

there's two checkstyle violations, could you please format the code?

@cjdxhjj
Copy link
Contributor Author

cjdxhjj commented Jan 9, 2024

@Nicole00 ok

@codecov-commenter
Copy link

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (312a4f2) 63.33% compared to head (4965191) 62.83%.

Files Patch % Lines
...va/com/vesoft/nebula/client/graph/SessionPool.java 0.00% 27 Missing ⚠️
.../com/vesoft/nebula/client/graph/NebulaSession.java 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #580      +/-   ##
============================================
- Coverage     63.33%   62.83%   -0.50%     
+ Complexity      812      811       -1     
============================================
  Files            72       72              
  Lines          4006     4036      +30     
  Branches        542      547       +5     
============================================
- Hits           2537     2536       -1     
- Misses         1098     1128      +30     
- Partials        371      372       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Nicole00 Nicole00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!Thanks @cjdxhjj very much!

@Nicole00 Nicole00 merged commit 8686d38 into vesoft-inc:master Jan 12, 2024
2 checks passed
@cjdxhjj
Copy link
Contributor Author

cjdxhjj commented Jan 12, 2024

@Nicole00 thanks

@QingZ11
Copy link

QingZ11 commented Mar 1, 2024

@Nicole00 thanks

Thank you for your great contribution, cjdxhjj.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants